[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/r47] maint: help2man targets should rely on the binaries th
|
From: |
Ralf Wildenhues |
|
Subject: |
Re: [PATCH 1/r47] maint: help2man targets should rely on the binaries they call. |
|
Date: |
Wed, 22 Sep 2010 20:22:46 +0200 |
|
User-agent: |
Mutt/1.5.20 (2010-08-04) |
* Eric Blake wrote on Wed, Sep 22, 2010 at 08:19:28PM CEST:
> On 09/22/2010 12:13 PM, Ralf Wildenhues wrote:
> >>Is it acceptable instead to use a nested $(MAKE) invocation prior to
> >>running help2man to ensure the binary is up-to-date?
> >
> >Can you show a patch so I can see what you mean?
>
> diff --git i/Makefile.am w/Makefile.am
> index 6e29a29..f74708c 100644
> --- i/Makefile.am
> +++ w/Makefile.am
> @@ -327,8 +327,10 @@ update_mans = \
> PATH=.$(PATH_SEPARATOR)$$PATH; export PATH; \
> $(HELP2MAN) --output=$@
> $(srcdir)/doc/libtool.1: $(srcdir)/$(auxdir)/ltmain.sh
> + $(MAKE) libtool
> $(update_mans) --help-option=--help-all libtool
When -jN has been passed, the two makes may both try to update 'libtool'
at the same time, leading to a race.
> $(srcdir)/doc/libtoolize.1: $(srcdir)/libtoolize.in
> + $(MAKE) libtoolize
> $(update_mans) libtoolize
Likewise here.
Cheers,
Ralf
- [PATCH 2/4] maint: rearrange Makefile.am in preparation for a follow-up patch., (continued)
Re: [PATCH 1/r47] maint: help2man targets should rely on the binaries they call., Gary V. Vaughan, 2010/09/22
[PATCH v2 01/11] maint: rearrange Makefile.am in preparation for a follow-up patch., Gary V. Vaughan, 2010/09/23
[PATCH v2 02/11] maint: don't leak developer GREP, SED etc into distribution file., Gary V. Vaughan, 2010/09/23