[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] tests: don't use assert/abort on MSVC as they are interactiv
From: |
Ralf Wildenhues |
Subject: |
Re: [PATCH] tests: don't use assert/abort on MSVC as they are interactive. |
Date: |
Tue, 28 Sep 2010 22:09:16 +0200 |
User-agent: |
Mutt/1.5.20 (2010-08-04) |
Hello Peter,
* Peter Rosin wrote on Tue, Sep 28, 2010 at 08:08:13PM CEST:
> Ok to push?
Avoiding assert doesn't seem like a scalable solution: lots of packages
use assert for testing. assert is ANSI C. We use assert in slist.at.
Is there a way to avoid popups?
Hmm, or, if there is no way, then I guess you're saying popups are ok if
it only happens for unexpected failures. Then I don't have a good
argument against the patch any more.
Thanks,
Ralf
> From f17e568aea90ea2def14d0d0825da927b4a2421d Mon Sep 17 00:00:00 2001
> From: Peter Rosin <address@hidden>
> Date: Tue, 28 Sep 2010 20:02:22 +0200
> Subject: [PATCH] tests: don't use assert/abort on MSVC as they are
> interactive.
>
> * tests/lalib-syntax.at (main.c): Rewrite to not use assert as
> assert in turn calls abort which pops up a dialog on MSVC.