Re: [PATCH] tests: don't use assert/abort on MSVC as they are interactive.

[Ralf Wildenhues]

Hi Peter,

* Peter Rosin wrote on Wed, Sep 29, 2010 at 10:06:00AM CEST:
> Ok to push this one?

I don't mind it, but I'll note that the patch will cause testsuite
failures when no wrapper is actually used.  This can happen

- with --disable-shared passed toplevel, or on static-only systems,
- on systems where a wrapper is not needed even in shared mode

At least for lalib-syntax it will thus cause failure for the wrong
reason (the current XFAIL hides that I guess).

For demo-relink that is irrelevant, as demo/main.c ignores its
arguments, tests/depdemo/main.c however also uses them.

(This need for internal knowledge about when wrappers are used, is why
I disliked the arguments to them; or am I misremembering and we have
changed the wrappers to be used in more cases for some reason?)

Hmm, --lt-no-interactive instead of --lt-no-popup, for consistency with
check-(non)interactive?

Thanks,
Ralf

> Subject: [PATCH] tests: make more tests non-interactive on MSYS.
> 
> * libltdl/config/ltmain.m4sh (func_emit_cwrapperexe_src):
> Recognize --lt-no-popup and set the w32 error mode so that
> Windows do not popup dialogs if the option is seen.
> * libltdl/config/ltmain.m4sh (func_parse_lt_options): Recognize
> --lt-no-popup and strip it out (with no side effect, there is
> no API for adjusting the w32 error mode from within a shell).
> * tests/demo-relink.test, tests/depdemo-relink.test: Use the
> above option to make the test non-interactive on MSYS.
> tests/lalib-syntax.at: Use the above option to make the test
> non-interactive on MSYS/MSVC (the MSVC version of assert/abort
> pops up an error dialog).
> * docs/libtool.texi (Wrapper executables): Document the new
> option of the wrapper.