[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
libtool-next patch queue
From: |
Ralf Wildenhues |
Subject: |
libtool-next patch queue |
Date: |
Fri, 15 Oct 2010 05:58:16 +0200 |
User-agent: |
Mutt/1.5.20 (2010-08-04) |
Hi Gary,
I promised I would look at your patch queue for rewriting bootstrap.
You pushed it to the libtool-next branch, so let me go through the
patches in that queue in order (re-stating this so everybody is on the
same page here, some of the messages involved unfortunately went
off-list for completely unrelated reasons; apologies for that).
The patch queue goes from
dd5b4f06557a4c5ec7b06d7814b95ecd63ab63b8^
to 0280c3687962199479258741cef4f32a2ccb8ffd
and for reference, I will just quote patches one by one here and/or
in followup mails, as appropriate.
The first three patches in the queue have previously been reviewed
already and their re-roll looks good to me. I have merged these three
into master now:
> From dd5b4f06557a4c5ec7b06d7814b95ecd63ab63b8 Mon Sep 17 00:00:00 2001
> From: Gary V. Vaughan <address@hidden>
> Date: Wed, 1 Sep 2010 14:41:52 +0700
> Subject: [PATCH 01/17] maint: rearrange Makefile.am in preparation for a
> follow-up patch.
>
> * Makefile.am (Libtool scripts.): Move this section below the
> `Bootstrap.' section...
> (libtoolize.in): ...except this one which is generated at
> bootstrap time, and was added into the `Bootstrap.' section.
> (Libltdl.): Move this section below the `Libtool scripts.'
> section.
> From c9497cc81cc46ce8848452240a323266440c4cb9 Mon Sep 17 00:00:00 2001
> From: Gary V. Vaughan <address@hidden>
> Date: Thu, 23 Sep 2010 17:00:08 +0700
> Subject: [PATCH 02/17] maint: don't leak developer GREP, SED etc into
> distribution file.
>
> * Makefile.am: Having rearranged the file, now apply the actual
> changes to follow-up.
> (edit): Split into two parts...
> (bootstrap_edit): ...substitutions that should happen at bootstrap
> time...
> (configure_edit): ...and substitutions that should not happen until
> configure time.
> * Makefile.am (libltdl/m4/ltversion.m4, libltdl/config/ltmain.sh)
> (libtoolize.in, tests/package.m4): Use bootstrap_edit.
> (libtoolize, tests/defs): Use configure_edit.
> * HACKING (Release Procedure): Remove the note to workaround the
> bug fixed by this changeset.
> * NEWS (Bug fixes): Mention that this bug is now fixed.
> Reported by Joerg Sonnenberger.
> From a2bb0c980f2b50ab31fedd18bb4890843b3d399a Mon Sep 17 00:00:00 2001
> From: Gary V. Vaughan <address@hidden>
> Date: Fri, 24 Sep 2010 12:51:36 +0700
> Subject: [PATCH 03/17] libtool: remove redundant unsubstituted shell var
> defaults.
>
> * Makefile.am (libltdl/config/ltmain.sh): Boilerplate code from
> libltdl/config/general.m4 sets some default shell variables
> designed to be substituted by `$(configure_edit)'. Actually,
> `libtool' uses the language tag values for those variables, and
> `ltmain.m4sh' is not passed through `$(configure_edit)', so they
> are just noise. Edit them out at bootstrap time.
The next patch needs fixes. I'll followup.
Cheers,
Ralf
- libtool-next patch queue,
Ralf Wildenhues <=