[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: 350-gary-maintain-private-libobj-namespace

From: Bob Friesenhahn
Subject: Re: 350-gary-maintain-private-libobj-namespace
Date: Thu, 31 Jan 2008 23:17:54 -0600 (CST)


This scrap of email from the libtool-patches list includes evidence that Ralf ran into the same problem that I ran into today. Something must be special about your environment.

Note Ralf's observation that lt_libobj_prefix is not set by configure.


On Wed, 30 Jan 2008, Gary V. Vaughan wrote:

Hallo Ralf,

On 30 Jan 2008, at 14:43, Ralf Wildenhues wrote:
* Gary V. Vaughan wrote on Tue, Jan 29, 2008 at 08:44:51AM CET:
On 29 Jan 2008, at 06:45, Ralf Wildenhues wrote:

I haven't reviewed your last two pending patches yet (but I'm not
telling you to wait for me).

Every little helps, even if you don't have time for a thorough review...

Your latest version of this patch is so badly mangled as to be
unapplicable.  This is not the first time it happens.  Please
consider sending patches as (text!) attachments, or at least
try to apply patches from your mails to see whether that works.

Sorry, I was pasting the patch into the body since you asked me not
to attach directly as that made it harder to review.  I didn't use
mailnotify because it breaks the thread.

Maybe will co-operate if I use a '.txt' extension for the
patch attachments?  Let me know if this is better.  If not, I'll
post with mailnotify, and put up with the broken message threading.

When I try to apply this patch by hand, build and install, get CVS
HEAD GraphicsMagick, and run its bootstrap script, I end up with this
failure, which I assume is due to one of your patches, or to messup
resulting from manual patch application.  Anyway you should look at
it before applying the patch (hint: lt_libobj_prefix seems not set
in configure):

/bin/sh ./libtool --silent --tag=CC --mode=link gcc -std=gnu99 -g -O2 -Wall -pthread -module -avoid-version -L/usr/X11R6/lib -L/usr/lib -L/usr/lib -o ltdl/ ltdl/loaders/dlopen.lo -ldl make[1]: *** No rule to make target `lt__strl.lo', needed by `ltdl/'. Stop.
make[1]: Leaving directory `/tmp/GraphicsMagick/build'
make: *** [all] Error 2

Works for me, I reran bootstrap, and launched a successful VPATH build.
Hopefully, you're just seeing a patch misapplication, otherwise we'll
have to figure out what is different for us.

Actually and bootstrap can be cleaned up for (tomorrow's)
libtool-2.1b.  .txt patch attached, and fingers crossed.

Index: b/libltdl/m4/ltdl.m4
--- a/libltdl/m4/ltdl.m4
+++ b/libltdl/m4/ltdl.m4
+    _ltdl_libobjs=
+    _ltdl_ltlibobjs=
+    if test -n "$_LT_LIBOBJS"; then
+      # Remove the extension.
+      sed_drop_objext='s/\.o$//;s/\.obj$//'

This is code that ends up in configure.  sed_drop_objext is not
namespace clean, please prefix with _lt_ or so.

Careless pasting from gnulib-tool.  CCing the gnulib list so they can
fix their version too... gl_sed_drop_objext?

+      for i in `for i in $_LT_LIBOBJS; do echo "$i"; done | sed
"$sed_drop_objext" | sort | uniq`; do

`sort -u' is portable.

Tx.  Fixed in the attached.

())_.              Email me: address@hidden
( '/           Read my blog:
/ )=         ...and my book:

Bob Friesenhahn
GraphicsMagick Maintainer,

reply via email to

[Prev in Thread] Current Thread [Next in Thread]