[Lilypond-auto] Issue 2934 in lilypond: The bug Context.Grob.property cleanup for \override et al

[lilypond]

Status: Started
Owner: address@hidden
Labels: Type-Enhancement

New issue 2934 by address@hidden: The bug Context.Grob.property cleanup for  
\override et al
http://code.google.com/p/lilypond/issues/detail?id=2934

This is the followup issue for issue 2883 where \override in general gets  
changed to
\override Context.Grob.property.subproperty = ...
As a result of that convert-ly rule, the diff gets too large for Rietveld  
to handle.  I am pushing this to the dev/syntax branch presently.   
Depending on the actual commit sequence of related and underlying issues,  
there might be a bit more of rebasing able to do, but not all that much.   
To get uniform syntax, this also changes \overrideProperty accordingly.

The current commit sequence as compared to master is

commit 1000c5701d1794b22c84af9a125302b95046ef89
Author: David Kastrup <address@hidden>
Date:   Sun Oct 28 14:16:51 2012 +0100

    Rerun scripts/auxiliar/update-with-convert-ly.sh

    This actually required several reverts in a row before rerunning the
    script, one for changes to input/regression/alter-broken.ly, and two
    for previous runs of update-with-convert-ly.sh.  Of course, afterwards
    reapplying the input/regression/alter-broken.ly change...

    Squashing several issues would make this easier.

commit a939f08a1dbe1c46b812db40cd9e6defd9a33d4d
Author: David Kastrup <address@hidden>
Date:   Wed Oct 10 14:31:27 2012 +0200

    Add more extensive rules for \tweak, \override, \revert,  
\overrideProperty

commit 71ec39a8ee88d226fa8c93923d01cf8612d36724
Author: David Kastrup <address@hidden>
Date:   Sun Oct 28 14:10:15 2012 +0100

    Change \overrideProperty to take a single symbol-list as path

commit 281ab61f8ad18d489d92bb1bce24a3746fd06c5f
Author: David Kastrup <address@hidden>
Date:   Sat Oct 27 21:08:17 2012 +0200

    Change input/regression/alter-broken.ly to include tweak-like usage

    Also change override-like usage for ties to \once\alterBroken as the
    control point manipulations are unlikely to be desirable for more than
    a single occurence.

commit a6af913d358840ea0354295b67e2c78cadaac38b
Author: David Kastrup <address@hidden>
Date:   Sat Oct 27 17:49:43 2012 +0200

    Rerun scripts/auxiliar/update-with-convert-ly.sh

    Because the version did not change, this required a git revert -n of the
    last such run beforehand.

commit 7890457255a314d0bf89c33cd7967fcdcd8cf10c
Author: David Kastrup <address@hidden>
Date:   Sat Oct 27 17:21:54 2012 +0200

    Change \alterBroken interface to match that of other tweak/overrides

commit 2691bac7b23a6bcd091e65dd7a617d376f5d9dfd
Author: David Kastrup <address@hidden>
Date:   Thu Oct 25 14:42:25 2012 +0200

    Implement function check-grob-path for checking/extending grob path  
specs

    From the function documentation string:

    Check a grob path specification @var{path}, a symbol list (or a
    single symbol), for validity and possibly complete it.  Returns the
    completed specification, or @code{#f} if invalid.  If optional
    @var{parser} is given, a syntax error is raised in that case,
    optionally using @var{location}.  If an optional keyword argument
    @code{#:start @var{start}} is given, the parsing starts at the given
    index in the sequence @samp{Context.Grob.property.sub-property...},
    with the default of @samp{0} implying the full path.

    If there is no valid first element of @var{path} fitting at the given
    path location, an optionally given @code{#:default @var{default}} is
    used as the respective element instead without checking it for
    validity at this position.

    The resulting path after possibly prepending @var{default} can be
    constrained in length by optional arguments @code{#:min @var{min}} and
    @code{#:max @var{max}}, defaulting to @samp{1} and unlimited,
    respectively.


The followup work will include documentation, changelog etc.  But please  
check whether you are ok with this substantial change going forward.