|
From: | Auto mailings of changes to Lily Issues via Testlilyissues-auto |
Subject: | [Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] Re: #5646 Switch to Python 3.x |
Date: | Wed, 22 Jan 2020 12:47:26 -0000 |
"Jonas Hahnfeld" address@hidden writes:
Did you apply all three patches?
https://codereview.appspot.com/545370043
https://codereview.appspot.com/573340043
https://codereview.appspot.com/561270043I have them in separate Rietveld issues because the second one is
actually generated, but as I wrote on lilypond-devel I propose to
commit them as one patch.
It's usually supposed the other way round: put them into one review (but
as separate diffs, so basically commit by commit) and, if you are fine
with that, as one merge commit with a short branch. Try
git log --graph 5385d029e3e4e89c1a7dba20d3e136f594321816
to get an example for how it looks when done right.
Basically reviews should compile, and so should mainline commits (for
the sake of bisection). If you feel insecure about creating such a
setup (basically the final merge has to be done with --no-ff in order to
actually get a separate merge commit), ask for someone else to do the
push.
--
David Kastrup
[issues:#5646] Switch to Python 3.x
Status: Started
Created: Thu Dec 19, 2019 06:15 PM UTC by Jonas Hahnfeld
Last Updated: Wed Jan 22, 2020 12:24 PM UTC
Owner: Jonas Hahnfeld
Switch to Python 3.x
Find and require at least Python 3.5 which will allow us to address
some deprecation warnings, most notably about the 'imp' module.
The major version 3.5 was first released in September 2015 and should
be available in all major distributions, including Ubuntu LTS 16.04 and
18.04 as well as CentOS/RHEL 7.x and 8.x.
http://codereview.appspot.com/545370043
Sent from sourceforge.net because address@hidden is subscribed to https://sourceforge.net/p/testlilyissues/issues/
To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/testlilyissues/admin/issues/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
_______________________________________________ Testlilyissues-auto mailing list address@hidden https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto
[Prev in Thread] | Current Thread | [Next in Thread] |