|
From: | Auto mailings of changes to Lily Issues via Testlilyissues-auto |
Subject: | [Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] Re: #5646 Switch to Python 3.x |
Date: | Wed, 22 Jan 2020 13:03:17 -0000 |
"Jonas Hahnfeld" address@hidden writes:
David, did you even carefully read my response?!? I'm doing exactly
that!
No, you aren't. They are not supposed to be 3 separate Rietveld issues
but a single issue with 2 updates to it.
Let me try again:
I have three commits locally: the switch itself, a generated patch by
2to3 and another patch to make it actually work. See above for the
three links, with this one being the SF issue to link them.
Now I can put this into one large issue on Rietveld, but you actually
don't want to review the second patch. So I have them separate to see
the manual changes that do need review.
That's why one puts them into separate updates so that people can select
the diffs to review.
On push, I will fuse them into one commit because a patch won't help
with bisection (git bisect might end up picking a commit from the
branch that doesn't actually compile).
That's why one puts just a merge commit in the mainline. See the
example I gave.
--
David Kastrup
[issues:#5646] Switch to Python 3.x
Status: Started
Created: Thu Dec 19, 2019 06:15 PM UTC by Jonas Hahnfeld
Last Updated: Wed Jan 22, 2020 12:58 PM UTC
Owner: Jonas Hahnfeld
Switch to Python 3.x
Find and require at least Python 3.5 which will allow us to address
some deprecation warnings, most notably about the 'imp' module.
The major version 3.5 was first released in September 2015 and should
be available in all major distributions, including Ubuntu LTS 16.04 and
18.04 as well as CentOS/RHEL 7.x and 8.x.
http://codereview.appspot.com/545370043
Sent from sourceforge.net because address@hidden is subscribed to https://sourceforge.net/p/testlilyissues/issues/
To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/testlilyissues/admin/issues/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
_______________________________________________ Testlilyissues-auto mailing list address@hidden https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto
[Prev in Thread] | Current Thread | [Next in Thread] |