lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: The new patch, slightly cleaned up, with (I hope) a proper Changelog


From: Han-Wen Nienhuys
Subject: Re: The new patch, slightly cleaned up, with (I hope) a proper Changelog
Date: Tue, 04 Apr 2006 12:17:12 +0200
User-agent: Thunderbird 1.5 (X11/20060313)

David Feuer wrote:
2006-04-03  David Feuer  <address@hidden>

* lilyponddefs.ps (set-ps-scale-to-lily-scale): Fixed code duplication.

* Cleaned up interfaces between PostScript and Scheme, and moved computations
from PostScript to Scheme:

* music-drawing-routines.ps
(*SF, stroke_and_fill): new procedures.  Replaced stroke and fill with
stroke_and_fill
throughout.
(euclidean_length, print_letter, draw_box): Deleted unused procedures.
 If someone
needs draw_box, implement it using draw_round_box; don't duplicate code.
(print_glyphs, draw_round_box, draw_polygon, draw_repeat_slash):
Refactored/cleaned up interfaces.
(mark_URI): Moved.
* output-ps.scm: reordered arguments to PostScript functions to match
new interfaces
(glyph-string): Rewrote glyph-string.
(grob-cause): Replaced string-append with format.
(repeat-slash): Rewrote to do computation here.
(round-filled-box): Rewrote to do computation here.

I hope this does it.


Thanks. Applied!

I have some more requests. For the patch, can send a patch with directory names? The output of

  diff -ur lilypond-2.9.1.OLD/ lilypond-2.9.1.NEW/

is fine. Alternatively, if you're using CVS, you can take the output of

  cvs diff -u

Could you also update Documentation/topdocs/AUTHORS.texi and THANKS in a next patch?

Thanks!

--

Han-Wen Nienhuys - address@hidden - http://www.xs4all.nl/~hanwen

LilyPond Software Design
 -- Code for Music Notation
http://www.lilypond-design.com





reply via email to

[Prev in Thread] Current Thread [Next in Thread]