[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Boxed text with rounded corners
From: |
Graham Percival |
Subject: |
Re: Boxed text with rounded corners |
Date: |
Mon, 21 Apr 2008 04:10:42 -0700 |
On Mon, 21 Apr 2008 10:02:45 +0200
"Valentin Villenave" <address@hidden> wrote:
> 2008/4/21 Graham Percival <address@hidden>:
>
> > -- actually, it might therefore be better to add the "category"
> > field to define-markup-command (or build-markup or whatever it's
> > called) *without* using an optional argument. That would force
> > programmers to give them a category (even if the category is
> > simply "other"), which is exactly what we want.
>
> I'd prefer to (but it's just because I can't handle the code
> otherwise ;)
>
> However, don't we risk a major breakage if doing so?
How should I know? I assume that you're going to compile lilypond
to check it; presumably that's what you did for your previous
patch. If for some reason you can't compile lilypond yourself any
more, send the patch to me and I'll try it on the GDP server.
As long as git compiles and produces decent docs, I think it's
safe to say that no "major breakage" has occurred. (also assuming that
the code is of good quality, easy to maintain, etc)
Cheers,
- Graham
- Re: Boxed text with rounded corners, Valentin Villenave, 2008/04/20
- Re: Boxed text with rounded corners, Graham Percival, 2008/04/20
- Re: Boxed text with rounded corners, Valentin Villenave, 2008/04/21
- Re: Boxed text with rounded corners, Graham Percival, 2008/04/21
- Re: Boxed text with rounded corners, Valentin Villenave, 2008/04/21
- Re: Boxed text with rounded corners,
Graham Percival <=
- RE: Boxed text with rounded corners, Carl D. Sorensen, 2008/04/21
- Re: Boxed text with rounded corners, Mats Bengtsson, 2008/04/21
- RE: Boxed text with rounded corners, Carl D. Sorensen, 2008/04/21