Re: PATCH: add dashed and dotted style for phrasing slurs

[Neil Puttock]

2008/11/22 Till Rettig <address@hidden>:
> Hi,
>
> could somebody please have a look at the attached patch which adds
> predefined commands for dashed and dotted phrasing slurs. Please apply it
> also to master, since I don't have a master branch set up to push.

LGTM.

A few nitpicks below:

+++ b/input/regression/phrasing-slur-dash.ly
@@ -0,0 +1,26 @@
+\version "2.11.51"

\version "2.11.65"

+\header {texidoc = "@cindex Phrasing slur, dotted, dashed

The @cindex entries don't go anywhere, it seems.

+The appearance of phrasing slurs may be changed from solid to dotted or dashed.
+"
+}
+\layout{ ragged-right=##t }

Don't need this, since it's the default for single line snippets.

+++ b/ly/property-init.ly
@@ -29,6 +29,20 @@ phrasingSlurUp = \override PhrasingSlur #'direction = #UP
 phrasingSlurDown = \override PhrasingSlur #'direction = #DOWN
 phrasingSlurNeutral = \revert PhrasingSlur #'direction

+%% There's also dash, but setting dash period/length should be fixed.

I'm pretty sure this comment is left over from when there were no
dash-period and dash-fraction settings for slurs, so it no longer
applies.

Cheers,
Neil