Re: order of alterations in Staff.keySignature for general keysignatures

[Reinhold Kainhofer]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Am Sonntag, 30. November 2008 16:41:14 schrieb Neil Puttock:
> 2008/11/30 Trevor Daniels <address@hidden>:
> > I've added a suitable comment to the snippet.
>
> I'm afraid it's not necessarily the case that they'll always be in
> reverse order, since the ordering is controlled by keyAlterationOrder
> (which obviously defaults to standard classical ordering).

No, the keyAlterationOrder only affects the generation of the keySignature 
alist from the pitch-alist of the KeyChangeEvent. The Key_engraver::read_event 
function also creates the keySignature list in the reverse order using the 
keyAlterationOrder...

Once the keySignature list is created (either by Key_engraver::read_event for 
standard \key settings or by setting it manually), the 
Key_engraver::create_key method only takes that list verbatim and prints its 
contents in reverse order...

I've played around a little bit, inserting three scm_reverse calls in key-
engraver.cc to make keySignature use the proper (unreversed) ordering of the 
alterations. I'll send a patch as soon as I've finished my other coding.

Cheers,
Reinhold
- -- 
- ------------------------------------------------------------------
Reinhold Kainhofer, Vienna University of Technology, Austria
email: address@hidden, http://reinhold.kainhofer.com/
 * Financial and Actuarial Mathematics, TU Wien, http://www.fam.tuwien.ac.at/
 * K Desktop Environment, http://www.kde.org, KOrganizer maintainer
 * Chorvereinigung "Jung-Wien", http://www.jung-wien.at/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iD8DBQFJMsV3TqjEwhXvPN0RAiRZAJ9SXVYdPfpaiKSprBWrRDI3kV39GgCgrQHC
WkuHpMj/wAfRoS3zjxJGywk=
=cWBM
-----END PGP SIGNATURE-----