[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH] Re: order of alterations in Staff.keySignature for general keysi
From: |
Reinhold Kainhofer |
Subject: |
[PATCH] Re: order of alterations in Staff.keySignature for general keysignatures |
Date: |
Sun, 30 Nov 2008 21:17:31 +0100 |
User-agent: |
KMail/1.10.3 (Linux/2.6.27-9-generic; KDE/4.1.3; i686; ; ) |
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Am Sonntag, 30. November 2008 17:55:19 schrieb Reinhold Kainhofer:
> No, the keyAlterationOrder only affects the generation of the keySignature
> alist from the pitch-alist of the KeyChangeEvent. The
> Key_engraver::read_event function also creates the keySignature list in the
> reverse order using the keyAlterationOrder...
>
> Once the keySignature list is created (either by Key_engraver::read_event
> for standard \key settings or by setting it manually), the
> Key_engraver::create_key method only takes that list verbatim and prints
> its contents in reverse order...
>
> I've played around a little bit, inserting three scm_reverse calls in key-
> engraver.cc to make keySignature use the proper (unreversed) ordering of
> the alterations. I'll send a patch as soon as I've finished my other
> coding.
So, here's the patch:
http://codereview.appspot.com/8686
Any idea if this is the correct way to solve the problem that you have to
enter non-standard key signatures in reverse order?
Cheers,
Reinhold
- --
- ------------------------------------------------------------------
Reinhold Kainhofer, Vienna University of Technology, Austria
email: address@hidden, http://reinhold.kainhofer.com/
* Financial and Actuarial Mathematics, TU Wien, http://www.fam.tuwien.ac.at/
* K Desktop Environment, http://www.kde.org, KOrganizer maintainer
* Chorvereinigung "Jung-Wien", http://www.jung-wien.at/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
iD8DBQFJMvTbTqjEwhXvPN0RAuybAJ9JK1ktS4ScNz37s+LB+gYtqHJSUgCg30J/
JznzL8zh5K5vVUjouKmoecA=
=Z7eO
-----END PGP SIGNATURE-----