lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] Re: horizontally centering denominator in compound time signatur


From: Reinhold Kainhofer
Subject: [PATCH] Re: horizontally centering denominator in compound time signatures
Date: Sun, 30 Nov 2008 23:42:10 +0100
User-agent: KMail/1.10.3 (Linux/2.6.27-9-generic; KDE/4.1.3; i686; ; )

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Am Sonntag, 30. November 2008 22:52:45 schrieb Reinhold Kainhofer:
> So, basically, there are two solutions:
> 1) Change stack-stencil-line to use the whole extents of the stencil (i.e.
> make it work correctly with stencils where the left edge is not at 0.
> 2) Change center-column to translate the stencil so that 0 lies at the left
> edge.
>
> Thinking about it, I suppose that 1) is the better solution. The only
> reason I see against it is to be able to let a stencil print something
> beyond its left edge. But then, a stencil can always print something beyond
> its extents, so there is no reason to special-case stack-stencil-line. It
> would even make sense to fix this for stencils where the left edge of the
> extent starts at a positive value. Those stencils get translated too much.
>
> What do you think is the correct solution?

I tried out both: 
If I only implement 1), then center-column markups that are not inside a line, 
but rather on their own, are still wrongly aligned (e.g. the first time 
signature in my examples). So 2) is definitely needed to fix this issue.

I've now implemented both:
http://codereview.appspot.com/8687

Comments please!

Cheers,
Reinhold
- -- 
- ------------------------------------------------------------------
Reinhold Kainhofer, Vienna University of Technology, Austria
email: address@hidden, http://reinhold.kainhofer.com/
 * Financial and Actuarial Mathematics, TU Wien, http://www.fam.tuwien.ac.at/
 * K Desktop Environment, http://www.kde.org, KOrganizer maintainer
 * Chorvereinigung "Jung-Wien", http://www.jung-wien.at/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iD8DBQFJMxbCTqjEwhXvPN0RArHnAJ4ydvjZ3QRxOl+xCtGrtTheyiQD8ACg1SZ+
EVbqcAKoR4kuEJIdE+ENTec=
=EjnV
-----END PGP SIGNATURE-----




reply via email to

[Prev in Thread] Current Thread [Next in Thread]