lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCHES] Re: Short tick as a bar line


From: Reinhold Kainhofer
Subject: [PATCHES] Re: Short tick as a bar line
Date: Sat, 13 Dec 2008 01:48:24 +0100
User-agent: KMail/1.10.3 (Linux/2.6.27-9-generic; KDE/4.1.3; i686; ; )

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Am Samstag, 13. Dezember 2008 00:55:11 schrieb Neil Puttock:
> 2008/12/12 Reinhold Kainhofer <address@hidden>:
> > Unfortunately, I'm running into one problem: It seems that for each
> > barline in a staff group the function is called multiple times and the
> > resulting stencil also shifted differently. In particular, for all staves
> > except the last in a staff group a tick is created through both the
> > top-most and the bottom-most staff line. An example is attached. Any idea
> > what is going on here?
>
> A span bar. :) You need to suppress it in Span_bar::calc_glyph_name ().

Ah, that makes sense! For the space between staves in a staff group, the 
Span_bar uses also a BarLine object of the same type, so it's actually a tick 
through the top-most virtual staff line of the space between the staves...

Okay, I uploaded a new patch:
http://codereview.appspot.com/10645/show

Now I set the bar line type for the span bar to "". Is this the correct way? 
Or should I rather completely suicide the object?

Cheers,
Reinhold

PS: I suppose that the dot bar style ( \bar"." ) should also remove the span 
bar... To be honest, I have no idea what the purpose of the "." bar style is, 
so I also don't know how it should work across staff groups. It was addd ages 
ago by hanwen (with an empty log message on 2005-11-29, right after 2.7.15), 
but it is nowhere documented or used...
Unless someone has a good reason, I thus propose to use \bar "." for a thick 
bar line instead. Patch is here:
    http://codereview.appspot.com/11044
Please review
- -- 
- ------------------------------------------------------------------
Reinhold Kainhofer, Vienna University of Technology, Austria
email: address@hidden, http://reinhold.kainhofer.com/
 * Financial and Actuarial Mathematics, TU Wien, http://www.fam.tuwien.ac.at/
 * K Desktop Environment, http://www.kde.org, KOrganizer maintainer
 * Chorvereinigung "Jung-Wien", http://www.jung-wien.at/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iD8DBQFJQwZZTqjEwhXvPN0RAmWgAKCcpKMBGSVttMvDm2K5JU/3bK2xhgCfY16b
m4x2LNARlHqE3OAf4zCoWAI=
=FmOs
-----END PGP SIGNATURE-----




reply via email to

[Prev in Thread] Current Thread [Next in Thread]