[PATCH] Re: Remarks about the building process

[John Mandereau]

Hi Han-Wen,

Sorry for the quite unreasonable delay, but I hope I've sorted out GCC
warnings mentioned in this thread.

Le samedi 08 novembre 2008 à 16:59 -0200, Han-Wen Nienhuys a écrit :
> +#define EPSNULL 1e-12

> this looks fishy.  Why another EPS value?  Joe?

I apologize for this obviously wrong patch, I must have messed up recent
and old patches.  I'll organize my patches in a better way from now,
with different directories for submitted and unsubmitted patches.


> +  if ((where
> +       && current_reps == SCM_EOL) || scm_is_pair (current_reps))
>      {
>        current_reps = scm_cons (what, current_reps);
>        where->set_property (reps, current_reps);
> 
> this is wrong.  In your version,  where can be NULL if current_reps is
> a pair, which lead to a crash.  Please double check all of the changes
> that may seem cosmetic.

I've done my best with my current understanding to do right changes.
BTW I'm trying rietveld, please review

http://codereview.appspot.com/11867

Best,
John