[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Tied accidentals in chords still taking up space (was: Issue 415 in
From: |
Han-Wen Nienhuys |
Subject: |
Re: Tied accidentals in chords still taking up space (was: Issue 415 in lilypond: Hidden accidental of tied note still takes space) |
Date: |
Sun, 29 Mar 2009 02:25:58 -0300 |
On Sat, Mar 28, 2009 at 11:51 PM, Chris Snyder
<address@hidden> wrote:
>>> I've glossed over the patch, and I am less than enthused: it seems to
>>> add a lot of special casing and duplicate code for the reminder and
>>> normal accidentals, and I have seen very dubious constructs like
>>> get_property("accidental-grob") rather than get_object.
>>
>> I'll review the code shortly; I agree that it should be get_object.
>
> I changed the get_object calls to get_property because the accidental-grob
> callback I added to notehead to return the correct accidental grob wasn't
> being called. What is the difference between objects and properties,
> anyways?
>
As far as I can remember, we do not actually have callbacks for objects.
--
Han-Wen Nienhuys - address@hidden - http://www.xs4all.nl/~hanwen
- Re: Tied accidentals in chords still taking up space (was: Issue 415 in lilypond: Hidden accidental of tied note still takes space), Chris Snyder, 2009/03/26
- Re: Tied accidentals in chords still taking up space (was: Issue 415 in lilypond: Hidden accidental of tied note still takes space), Joe Neeman, 2009/03/26
- Re: Tied accidentals in chords still taking up space (was: Issue 415 in lilypond: Hidden accidental of tied note still takes space), Han-Wen Nienhuys, 2009/03/28
- Re: Tied accidentals in chords still taking up space (was: Issue 415 in lilypond: Hidden accidental of tied note still takes space), Han-Wen Nienhuys, 2009/03/29
- Re: Tied accidentals in chords still taking up space (was: Issue 415 in lilypond: Hidden accidental of tied note still takes space), Han-Wen Nienhuys, 2009/03/29
- Re: Tied accidentals in chords still taking up space (was: Issue 415 in lilypond: Hidden accidental of tied note still takes space), Joe Neeman, 2009/03/29
- Re: Tied accidentals in chords still taking up space (was: Issue 415 in lilypond: Hidden accidental of tied note still takes space), Han-Wen Nienhuys, 2009/03/29
- Re: Tied accidentals in chords still taking up space (was: Issue 415 in lilypond: Hidden accidental of tied note still takes space), Mark Polesky, 2009/03/29
- Re: Tied accidentals in chords still taking up space (was: Issue 415 in lilypond: Hidden accidental of tied note still takes space), Han-Wen Nienhuys, 2009/03/29