[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] New margin handling - final version (updated)
From: |
Patrick McCarty |
Subject: |
Re: [PATCH] New margin handling - final version (updated) |
Date: |
Fri, 11 Sep 2009 15:40:55 -0700 |
On Fri, Sep 11, 2009 at 3:33 PM, Michael Käppler <address@hidden> wrote:
> Hi Neil,
> I'm fine with all your comments...
>>
>> The regression test would probably benefit from being split into
>> several separate tests, particularly the final check-consistency
>> setting, which can then have #(ly:set-option 'warning-as-error #f)
>> added to it in anticipation of the mythical time when we can switch
>> this option on for regression testing. :)
>
> ...however, I don't really understand the benefit of splitting the regtest.
> Do you propose to have separate files for each combination of settings?
>
> And if warning-as-error was set to true, the regtest would fail. I don't
> think that is intended, since the >absence< of the warning would be wrong
> behaviour, not the appearance.
If you *want* the warning(s) for regtests, add
#(ly:set-option 'warning-as-error #f)
as Neil suggested. Eventually, this option will be set to #t for
regtest compilation, thus the need for overriding the default
behavior.
Thanks,
Patrick
- Re: [PATCH] New margin handling - final version (updated), (continued)
- Re: [PATCH] New margin handling - final version (updated), Michael Käppler, 2009/09/20
- Re: [PATCH] New margin handling - final version (updated), Neil Puttock, 2009/09/21
- Re: [PATCH] New margin handling - final version (updated), Michael Käppler, 2009/09/22
- Re: [PATCH] New margin handling - final version (updated), Neil Puttock, 2009/09/25
- Re: [PATCH] New margin handling - final version (updated), Michael Käppler, 2009/09/25
- Re: [PATCH] New margin handling - final version (updated), Neil Puttock, 2009/09/25
- Re: [PATCH] New margin handling - final version (updated), John Mandereau, 2009/09/25
- Re: [PATCH] New margin handling - final version (updated), Michael Käppler, 2009/09/26
- Re: [PATCH] New margin handling - final version (updated), Michael Käppler, 2009/09/30
- Re: [PATCH] New margin handling - final version (updated), Michael Käppler, 2009/09/11
- Re: [PATCH] New margin handling - final version (updated),
Patrick McCarty <=
- Re: [PATCH] New margin handling - final version (updated), Neil Puttock, 2009/09/12
- Re: [PATCH] New margin handling - final version (updated), Michael Käppler, 2009/09/11