[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] New margin handling - final version (updated)
From: |
John Mandereau |
Subject: |
Re: [PATCH] New margin handling - final version (updated) |
Date: |
Sat, 26 Sep 2009 01:18:29 +0200 |
Le vendredi 25 septembre 2009 à 23:59 +0100, Neil Puttock a écrit :
> LGTM, though I'd appreciate it if somebody else could give the patch a
> final look (especially the lilypond-book changes, since I'm not that
> familiar with it).
Sure, see below.
> --- a/scripts/lilypond-book.py
> +++ b/scripts/lilypond-book.py
> + # FIXME: This is really ugly. Every setting should be there only once,
> + # instead of having several line-width = foo / line-width = blah
> + # constructs. This would affect also QUOTE / LILYQUOTE, however.
This comment reveals a larger issue than the code it comments, so I
suggest to move it away from lilypond-book.py and rewrite it in Git
commit message and/or an issue on the tracker.
Best,
John
signature.asc
Description: Ceci est une partie de message numériquement signée
- Re: [PATCH] New margin handling - final version (updated), (continued)
- Re: [PATCH] New margin handling - final version (updated), Michael Käppler, 2009/09/14
- Re: [PATCH] New margin handling - final version (updated), Neil Puttock, 2009/09/19
- Re: [PATCH] New margin handling - final version (updated), Michael Käppler, 2009/09/20
- Re: [PATCH] New margin handling - final version (updated), Neil Puttock, 2009/09/21
- Re: [PATCH] New margin handling - final version (updated), Michael Käppler, 2009/09/22
- Re: [PATCH] New margin handling - final version (updated), Neil Puttock, 2009/09/25
- Re: [PATCH] New margin handling - final version (updated), Michael Käppler, 2009/09/25
- Re: [PATCH] New margin handling - final version (updated), Neil Puttock, 2009/09/25
- Re: [PATCH] New margin handling - final version (updated),
John Mandereau <=
- Re: [PATCH] New margin handling - final version (updated), Michael Käppler, 2009/09/26
- Re: [PATCH] New margin handling - final version (updated), Michael Käppler, 2009/09/30
- Re: [PATCH] New margin handling - final version (updated), Michael Käppler, 2009/09/11
- Re: [PATCH] New margin handling - final version (updated), Patrick McCarty, 2009/09/11
- Re: [PATCH] New margin handling - final version (updated), Neil Puttock, 2009/09/12
- Re: [PATCH] New margin handling - final version (updated), Michael Käppler, 2009/09/11