Re: [PATCH] Re: 2.13.10 pre-release testing

[Reinhold Kainhofer]

Am Donnerstag, 31. Dezember 2009 12:26:39 schrieb Reinhold Kainhofer:
> Am Donnerstag, 31. Dezember 2009 11:29:14 schrieb Trevor Daniels:
> > convert-ly - OK, except
> >   Happened to try a file with \version "2.10"
> >   This causes a python index error.
> 
> Ouch, convert-ly assumed that all version strings always consist of three
> entries... I've created a patch to really check for this and normalize the
> version to a three-entry tuple if the version has more/fewer levels:
> 
> http://codereview.appspot.com/183097

I agree with Graham that it is better in this case to simply trigger an error 
message and tell the user to fix the file (e.g. if the user mistypes 2.12.2 as 
2.1.2.2, we don't want to apply all conversion rules from 2.1 to 2.13)...

So, here's an updated patch, which checks for three-entry tuples as version 
numbers and prints out an understandable error message instead of making 
stupid assumptions.

http://codereview.appspot.com/183097

Okay to apply this time?

Cheers,
Reinhold
-- 
------------------------------------------------------------------
Reinhold Kainhofer, address@hidden, http://reinhold.kainhofer.com/
 * Financial & Actuarial Math., Vienna Univ. of Technology, Austria
 * http://www.fam.tuwien.ac.at/, DVR: 0005886
 * LilyPond, Music typesetting, http://www.lilypond.org