Re: Enhancement: Page breaking to avoid widow lines

[Boris Shingarov]

Here is the new code -- implementing all that's been discussed.  (Ok, 
not quite all -- the line length functionality is not implemented, but 
all the style remarks have been taken into account, the markup-list-id 
has been replaced with is-last-line, penalty made configurable, and 
also, (new, was not discussed yet), the opposite case of lonely first 
(as opposed to last) line is now properly handled. 

Quoting Joe Neeman <address@hidden>:
> On Wed, 2010-01-13 at 09:11 -0500, Boris Shingarov wrote:
> > Joe,
> >
> > > Paper_book::get_system_specs then you wouldn't even need the
> > > markup-list-id property: you could add an avoid-orphan property that
> > > only gets set for the last line of a multi-line markup list if it is
> > > short. That might also simplify Page_spacer::calc_subproblem. 
> >
> > This is the first idea that came to my mind when I started implementing
> > this code. 
> > I wanted to have a member called "is_last_line_" instead of
> > "markup_list_id_", that way the nested ifs in calc_subproblem() become
> > much more readable.  But I wasn't sure how to calculate that property
> > inside the Line_details(...) constructor. 
>
> Can't you do it in Paper_book::get_system_specs and store it in the Prob
> (and then read it from the Prob in Line_details(Prob*))?
>
> Joe

lily.diff
Description: Text Data