Re: Rietveld review

[Reinhold Kainhofer]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Am Dienstag, 4. Mai 2010 10:51:05 schrieb David Kastrup:
> Contained patch sets can be reasonably well exchanged by mail/mailing
> list.

My experience with this is that patches sent by mail will be forgotten the 
next day. So, either you are lucky to get a response on the first day, or you 
will never... I definitely prefer a reviewboard like rietvield (in KDE Pim we 
also have our own reviewboard, which works a bit differently, but just as 
well).
I have not eperienced the problems you are complaining about. In particular, 
my patch for AJAX search in the docs was created 13 months ago, and recently 
rebased/updated to current master. (http://codereview.appspot.com/24076/ )
Of course,  updating the patch to current master took some time, because the 
whole documentation file tree was completely overhauled. But you'll have that 
problem in all cases, no matter whether you use rietvield, repo.or.cz or 
patches sent via mail...

Plus, a simple  "git-cl upload origin/master" after the rebase is just soo 
much easier than generating patch files and attaching them to mails.

Cheers,
Reinhold
- -- 
- ------------------------------------------------------------------
Reinhold Kainhofer, Vienna University of Technology, Austria
email: address@hidden, http://reinhold.kainhofer.com/
 * Financial and Actuarial Mathematics, TU Wien, http://www.fam.tuwien.ac.at/
 * Edition Kainhofer Music Publishing, http://www.edition-kainhofer.com/
 * LilyPond music typesetting software, http://www.lilypond.org/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iEYEARECAAYFAkvf8rAACgkQTqjEwhXvPN270wCfTAM8BpN640HSWftXpHtD8wbJ
LToAn1u2fXQKuZBGRMqO9MyF8UFjhQvA
=W7BR
-----END PGP SIGNATURE-----