[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Issue 915 Multi-measure rests dependent on prefatory matter in othe
From: |
Neil Puttock |
Subject: |
Re: Issue 915 Multi-measure rests dependent on prefatory matter in other staves |
Date: |
Sat, 15 May 2010 16:01:04 +0100 |
On 15 May 2010 14:37, Karl Hammar <address@hidden> wrote:
> git-pull
> wget http://codereview.appspot.com/download/issue931041_1.diff
> patch -p1 < issue931041_1.diff --dry-run
> patch -p1 < issue931041_1.diff
> make > log 2>&1; make test-redo >> log 2>&1
I very rarely use `make test-redo'.
I basically do what Carl outlined in the other thread:
make test-baseline
git apply issue931041_1.diff
make check
> Also, it would be much easier to look throuht the patch if it did not
> contain so many whitespace changes. In the first 100lines, I see:
Why would you want to look at the bare diff? The whole point of
uploading the patchset to Rietveld is to make it easier to see the
changes in each file.
Regards,
Neil
multi-measure-rest-multi-staff-center.compare.jpeg
Description: JPEG image
- Issue 915 Multi-measure rests dependent on prefatory matter in other staves, Karl Hammar, 2010/05/15
- Re: Issue 915 Multi-measure rests dependent on prefatory matter in other staves, Neil Puttock, 2010/05/15
- Re: Issue 915 Multi-measure rests dependent on prefatory matter in other staves, Graham Percival, 2010/05/16
- Re: Issue 915 Multi-measure rests dependent on prefatory matter in other staves, Graham Percival, 2010/05/16
- Re: Issue 915 Multi-measure rests dependent on prefatory matter in other staves, Neil Puttock, 2010/05/16
- Re: Issue 915 Multi-measure rests dependent on prefatory matter in other staves, Graham Percival, 2010/05/16
- Re: Issue 915 Multi-measure rests dependent on prefatory matter in other staves, Karl Hammar, 2010/05/16