[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Add independent control of thickness and offset for underline markup
From: |
Carl Sorensen |
Subject: |
Re: Add independent control of thickness and offset for underline markup (issue1347041) |
Date: |
Fri, 28 May 2010 15:06:39 -0600 |
On 5/28/10 2:29 PM, "address@hidden" <address@hidden> wrote:
> Hi Kieren,
>
> I don't think we can remove the link between 'line-thickness and
> underline offset, since it should scale based on staff-size. At small
> staff-sizes, 'line-thickness gets progressively larger, which matches
> the thicker underline with a slightly bigger gap.
Couldn't we define the offset as a multiple of 'line-thickness, instead of
an absolute value? That's how fret diagrams are scaled.
>
> http://codereview.appspot.com/1347041/diff/1/2#newcode301
> scm/define-markup-commands.scm:301: (y (* -1 offset))
(y (* thick (- offset)))
Thanks,
Carl