[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH]: Fix issue 1096
From: |
Reinhold Kainhofer |
Subject: |
Re: [PATCH]: Fix issue 1096 |
Date: |
Sat, 29 May 2010 22:05:42 +0200 |
User-agent: |
KMail/1.13.3 (Linux/2.6.32-22-generic; KDE/4.4.3; i686; ; ) |
Am Samstag, 29. Mai 2010, um 17:04:34 schrieb Benjamin Peterson:
> 2010/5/28 Reinhold Kainhofer <address@hidden> schrieb:
> > Am Donnerstag, 27. Mai 2010, um 15:39:46 schrieb Carl Sorensen:
> >> Benjamin Peterson prepared a patch to fix this issue.
> >>
> >> It's in the lexer, and I'm not at all comfortable with the lexer.
> >> However, the patch has been demonstrated to work and to not break the
> >> regtests.
> >
> > Actually, while it does not break any current regtests, it does not work
> > in all cases.
>
> Thank you for your extensive tests. Before addressing the problems,
> though, I was wondering what your use-case for ly:parser-parser-file
> is. Is it to include a programmatically created string into the
> current file as if with an \include?
Yes, the two cases where we encountered a problem with ly:parser-parse-string
were:
-) Including files just once. I.e. if a file had already been included, don't
include it a second time
-) Conditionally including a user-specified init file: in ly/init.ly do
something similar to \include, but use the file name specified in a command
line option. This has to be done in scheme, since scheme is needed to evaluate
the command-line arguments.
> If so, I think a new interface,
> that would simply insert the string into the current stream would make
> more sense.
Yes, you are probably right. However, I don't know enough of the parser
internals to implement this myself :(
Cheers,
Reinhold
--
------------------------------------------------------------------
Reinhold Kainhofer, address@hidden, http://reinhold.kainhofer.com/
* Financial & Actuarial Math., Vienna Univ. of Technology, Austria
* http://www.fam.tuwien.ac.at/, DVR: 0005886
* LilyPond, Music typesetting, http://www.lilypond.org
- [PATCH]: Fix issue 1096, Carl Sorensen, 2010/05/27
- Re: [PATCH]: Fix issue 1096, David Kastrup, 2010/05/27
- Re: [PATCH]: Fix issue 1096, Carl Sorensen, 2010/05/27
- Re: [PATCH]: Fix issue 1096, Graham Percival, 2010/05/27
- Re: [PATCH]: Fix issue 1096, Carl Sorensen, 2010/05/27
- Re: [PATCH]: Fix issue 1096, Benjamin Peterson, 2010/05/27
- Re: [PATCH]: Fix issue 1096, Carl Sorensen, 2010/05/27
- Re: [PATCH]: Fix issue 1096, David Kastrup, 2010/05/28
Re: [PATCH]: Fix issue 1096, Reinhold Kainhofer, 2010/05/27
Message not available