Re: T1265 - Remove deprecation warnings when running with Guile V2 (issue2204044)

[pnorcks]

Hi Ian,

Just a few more comments for you.

I am okay with using scm_to_uint(); that looks like a safe route for us
to take.

Thanks,
Patrick


http://codereview.appspot.com/2204044/diff/14001/flower/include/guile-compatibility.hh
File flower/include/guile-compatibility.hh (right):

http://codereview.appspot.com/2204044/diff/14001/flower/include/guile-compatibility.hh#newcode28
flower/include/guile-compatibility.hh:28: #define scm_to_unsigned(x)
scm_to_uint (x)
This macro is not needed, either, AFAICS.

If you say

  #define FOO 1

all instances of FOO are replaced with 1.

With this patch, you do away with the one instance of
"scm_to_unsigned(x)", replacing it with "scm_to_uint(x)".  Since
"scm_to_unsigned(x)" no longer appears in the code base (after applying
this patch), this macro does nothing.

http://codereview.appspot.com/2204044/diff/14001/flower/include/guile-compatibility.hh#newcode30
flower/include/guile-compatibility.hh:30: #else  // SCM_MINOR_VERSION >
6 && SCM_MINOR_VERSION >= 9
Just about :)

The comment is now redundant...

This should be

#else // SCM_MINOR_VERSION >= 9

http://codereview.appspot.com/2204044/diff/14001/lily/dispatcher.cc
File lily/dispatcher.cc (right):

http://codereview.appspot.com/2204044/diff/14001/lily/dispatcher.cc#newcode195
lily/dispatcher.cc:195: }
Please fix the indentation here (revert to using a tab).

http://codereview.appspot.com/2204044/diff/14001/lily/include/lily-guile-macros.hh
File lily/include/lily-guile-macros.hh (right):

http://codereview.appspot.com/2204044/diff/14001/lily/include/lily-guile-macros.hh#newcode146
lily/include/lily-guile-macros.hh:146: TYPE ## _ ## FUNC ##
_init_functions);
Revert back to tabs here.

http://codereview.appspot.com/2204044/