lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

T1249 - Remove (define define-ly-syntax define-public). (issue2313044)


From: pnorcks
Subject: T1249 - Remove (define define-ly-syntax define-public). (issue2313044)
Date: Fri, 08 Oct 2010 05:00:01 +0000


http://codereview.appspot.com/2313044/diff/1/scm/ly-syntax-constructors.scm
File scm/ly-syntax-constructors.scm (left):

http://codereview.appspot.com/2313044/diff/1/scm/ly-syntax-constructors.scm#oldcode20
scm/ly-syntax-constructors.scm:20: (define define-ly-syntax
define-public)
Instead of removing this definition (like I did), would it be possible
to use a macro here?  Something like

  (defmacro define-ly-syntax (args . body)
    `(define-public ,args ,body))

This is untested.

http://codereview.appspot.com/2313044/diff/1/scm/ly-syntax-constructors.scm
File scm/ly-syntax-constructors.scm (right):

http://codereview.appspot.com/2313044/diff/1/scm/ly-syntax-constructors.scm#newcode27
scm/ly-syntax-constructors.scm:27: `(define-public ,args
I forgot why I changed this...

Is there a reason why "primitive-eval" was used here in the first place?

http://codereview.appspot.com/2313044/diff/1/scm/ly-syntax-constructors.scm#newcode250
scm/ly-syntax-constructors.scm:250: (define-public (partial parser
location dur)
This part needs to be rebased against current master.

http://codereview.appspot.com/2313044/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]