[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Tweaks regtest and adds avoid-collisions property (issue4022045)
From: |
address@hidden |
Subject: |
Re: Tweaks regtest and adds avoid-collisions property (issue4022045) |
Date: |
Thu, 3 Feb 2011 20:24:41 -0500 |
On Feb 3, 2011, at 7:33 PM, address@hidden wrote:
> Hey Mike,
>
> could you make a separate patch for the engraver, fixing the issue
> below; I think the engraver can go in without further discussion.
>
>
> http://codereview.appspot.com/4022045/diff/12001/lily/beam-collision-engraver.cc
> File lily/beam-collision-engraver.cc (right):
>
> http://codereview.appspot.com/4022045/diff/12001/lily/beam-collision-engraver.cc#newcode107
> lily/beam-collision-engraver.cc:107: }
> I think you are adding the note heads of the beam itself here as well.
> Can you make sure you only do that for noteheads from other voices?
>
> http://codereview.appspot.com/4022045/
Done & attached, but I don't know if it's a good idea to put an engraver in the
source that doesn't do anything yet. That said, I don't mind sharing it as a
patch if you (or anyone else) wants to build work off of it.
Cheers,
MS
0002-Adds-beam-collision-engraver.patch
Description: Binary data