lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Add dots to tocItemMarkup (issue4182056)


From: Carl . D . Sorensen
Subject: Re: Add dots to tocItemMarkup (issue4182056)
Date: Thu, 17 Feb 2011 03:19:04 +0000

Looks good.  I had one comment.

Feel free to add an entry to the changelog.  It's done by editing the
file Documentation/changes.tely

Thanks,

Carl



http://codereview.appspot.com/4182056/diff/7001/scm/define-markup-commands.scm
File scm/define-markup-commands.scm (right):

http://codereview.appspot.com/4182056/diff/7001/scm/define-markup-commands.scm#newcode3403
scm/define-markup-commands.scm:3403: (define-markup-command (pattern
layout props pattern count space)
Now that I see it written -- should there be a direction argument for
pattern? Or at least should we document that it's a horizontal repeat?

http://codereview.appspot.com/4182056/diff/7001/scm/define-markup-commands.scm#newcode3416
scm/define-markup-commands.scm:3416: (if (zero? i)
Nicely done!

http://codereview.appspot.com/4182056/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]