Re: Draws a line above footnotes (issue4167063)

[joeneeman]

http://codereview.appspot.com/4167063/diff/3018/lily/note-head.cc
File lily/note-head.cc (right):

http://codereview.appspot.com/4167063/diff/3018/lily/note-head.cc#newcode189
lily/note-head.cc:189: "footnote "
Any particular reason this belongs to note-head-interface (rather than,
say, item-interface)?

http://codereview.appspot.com/4167063/diff/3018/lily/page-breaking.cc
File lily/page-breaking.cc (right):

http://codereview.appspot.com/4167063/diff/3018/lily/page-breaking.cc#newcode516
lily/page-breaking.cc:516: Page_breaking::draw_page (SCM systems, SCM
footnotes, SCM configuration, int page_num, bool last)
Surely draw_page can extract the footnotes from the systems rather than
taking them as an argument? Then you don't have to keep passing them
around, and you get support for the other page breaking algorithms for
free.

http://codereview.appspot.com/4167063/diff/3018/lily/page-layout-problem.cc
File lily/page-layout-problem.cc (right):

http://codereview.appspot.com/4167063/diff/3018/lily/page-layout-problem.cc#newcode65
lily/page-layout-problem.cc:65: Stencil mol;
Why not make the separator a (stencil-valued) property of the
paper-book?

http://codereview.appspot.com/4167063/diff/3018/lily/page-spacing.cc
File lily/page-spacing.cc (right):

http://codereview.appspot.com/4167063/diff/3018/lily/page-spacing.cc#newcode81
lily/page-spacing.cc:81: for (vsize i = 0; i < line.footnotes_.size ();
i++)
You'll need to do this in append_system also.

http://codereview.appspot.com/4167063/diff/3018/lily/system.cc
File lily/system.cc (right):

http://codereview.appspot.com/4167063/diff/3018/lily/system.cc#newcode623
lily/system.cc:623: footnote_search (Grob *g, vsize start, vsize end,
vector<Stencil*>* s)
Have you checked the performance of this? This part is linear and so it
makes break_into_pieces quadratic. Also, you can make it simpler by
iterating through "all-elements" instead of recursing through
"elements".

http://codereview.appspot.com/4167063/