lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Reduces algorithm time by prefinding footnoted grobs (issue4213042)


From: mtsolo
Subject: Re: Reduces algorithm time by prefinding footnoted grobs (issue4213042)
Date: Mon, 28 Feb 2011 23:50:49 +0000


http://codereview.appspot.com/4213042/diff/35006/lily/footnote-engraver.cc
File lily/footnote-engraver.cc (right):

http://codereview.appspot.com/4213042/diff/35006/lily/footnote-engraver.cc#newcode67
lily/footnote-engraver.cc:67: b->set_property ("footnote-text",
event->get_property ("footnote-text"));
On 2011/02/28 23:39:45, Neil Puttock wrote:
remove and add default in define-grobs.scm via
`grob::calc-property-by-copy'

Done.

http://codereview.appspot.com/4213042/diff/35006/lily/footnote-engraver.cc#newcode68
lily/footnote-engraver.cc:68: b->set_property ("text",
event->get_property ("text"));
On 2011/02/28 23:39:45, Neil Puttock wrote:
remove

Done.

http://codereview.appspot.com/4213042/diff/35006/lily/footnote-engraver.cc#newcode79
lily/footnote-engraver.cc:79: Grob *b = make_item ("FootnoteItem",
event->self_scm ());
On 2011/02/28 23:39:45, Neil Puttock wrote:
remove and add default in define-grobs.scm via
`grob::calc-property-by-copy'

Done.

http://codereview.appspot.com/4213042/diff/35006/lily/footnote-engraver.cc#newcode80
lily/footnote-engraver.cc:80: b->set_property ("footnote-text",
event->get_property ("footnote-text"));
On 2011/02/28 23:39:45, Neil Puttock wrote:
remove

Done.

http://codereview.appspot.com/4213042/diff/35006/ly/music-functions-init.ly
File ly/music-functions-init.ly (right):

http://codereview.appspot.com/4213042/diff/35006/ly/music-functions-init.ly#newcode355
ly/music-functions-init.ly:355: 'footnote-text footnote))
On 2011/02/28 23:39:45, Neil Puttock wrote:
add 'footnote-text to define-music-properties.scm

Done.

http://codereview.appspot.com/4213042/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]