lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Adds footnote-footer-padding to the paper bloc. (issue4384046)


From: address@hidden
Subject: Re: Adds footnote-footer-padding to the paper bloc. (issue4384046)
Date: Sat, 9 Apr 2011 06:33:56 -0400

On Apr 8, 2011, at 5:27 PM, address@hidden wrote:

> LGTM, just needs a regtest.
> 
> 
> http://codereview.appspot.com/4384046/diff/5001/lily/page-spacing.cc
> File lily/page-spacing.cc (right):
> 
> http://codereview.appspot.com/4384046/diff/5001/lily/page-spacing.cc#newcode88
> lily/page-spacing.cc:88: return footnote_height
> (footnote_height
> 
> to preserve indent
> 
> http://codereview.appspot.com/4384046/diff/5001/ly/paper-defaults-init.ly
> File ly/paper-defaults-init.ly (right):
> 
> http://codereview.appspot.com/4384046/diff/5001/ly/paper-defaults-init.ly#newcode111
> ly/paper-defaults-init.ly:111: footnote-footer-padding = 0.5\mm
> add to `set-paper-dimension-variables' (same for footnote-padding)
> otherwise it's 0.5 staff-space

Thanks!
Pushed as c676b77a6e685d6efbbeb358f8488725fbab34d2

Cheers,
MS


reply via email to

[Prev in Thread] Current Thread [Next in Thread]