Re: Allows glissandi between chords (issue4442082)

[address@hidden]

On Apr 26, 2011, at 7:30 AM, address@hidden wrote:

> Excellent work!

Thanks!

> A couple of comments below.
> 
> http://codereview.appspot.com/4442082/diff/3001/scm/define-context-properties.scm
> File scm/define-context-properties.scm (right):
> 
> http://codereview.appspot.com/4442082/diff/3001/scm/define-context-properties.scm#newcode260
> scm/define-context-properties.scm:260: (glissandoMap ,list? "A map in
> the form of '((source1 . target1)
> I think we ought to enable the current behavior (one glissando line per
> chord, instead of one per note) to be kept (so we won't break existing
> scores). Perhaps a value of #f should be used to indicate keeping the
> old behavior.
> 

The old behavior can be achieved via:

\set glissandoMap = #'((0 . 0))

What would be the appropriate .ly file in ly/ to put this in?

> http://codereview.appspot.com/4442082/diff/3001/scm/define-grob-interfaces.scm
> File scm/define-grob-interfaces.scm (right):
> 
> http://codereview.appspot.com/4442082/diff/3001/scm/define-grob-interfaces.scm#newcode103
> scm/define-grob-interfaces.scm:103: '(glissando-index))
> As I mention elsewhere, I don't think this is a user property, so
> needn't be included in the interface.
> 

See below.

> http://codereview.appspot.com/4442082/diff/3001/scm/define-grob-properties.scm
> File scm/define-grob-properties.scm (right):
> 
> http://codereview.appspot.com/4442082/diff/3001/scm/define-grob-properties.scm#newcode412
> scm/define-grob-properties.scm:412: (glissando-index ,integer? "The
> index of a glissando in its note
> It seems to me like this should be an internal grob property, rather
> than a user grob property, and that it need not be part of an interface.
> I can't imagine how it ought to be tweaked by the user.

Even if a property is moved to an internal property in 
define-grob-properties.scm, doesn't it still need to be declared in an 
interface so that internals.texi may be written?

Cheers,
MS