Gets rid of chordGlissando. (issue4444066)

[mtsolo]

Reviewers: ,

Message:
To be pushed after 4442082 is pushed.

Description:
Gets rid of chordGlissando.

Please review this at http://codereview.appspot.com/4444066/

Affected files:
  M Documentation/de/notation/fretted-strings.itely
  M Documentation/de/texidocs/chord-glissando-in-tablature.texidoc
  M Documentation/es/notation/fretted-strings.itely
  M Documentation/es/texidocs/chord-glissando-in-tablature.texidoc
  M Documentation/notation/fretted-strings.itely
  M Documentation/snippets/new/chord-glissando-in-tablature.ly
  M ly/music-functions-init.ly


Index: Documentation/de/notation/fretted-strings.itely
diff --git a/Documentation/de/notation/fretted-strings.itely  
b/Documentation/de/notation/fretted-strings.itely
index  
e4e56f10c5fb1a3e5ce4c22a618253bc98803ee7..5911f2ccd5879d30a4cc42c2f5fe6f24b2921755  
100644
--- a/Documentation/de/notation/fretted-strings.itely
+++ b/Documentation/de/notation/fretted-strings.itely
@@ -375,7 +375,6 @@ ties = \relative c' {
 @funindex \harmonic
 @funindex \harmonicByFret
 @funindex \harmonicByRatio
address@hidden \chordGlissando

 Flageolett (engl. @emph{harmonic}) kann zur Tabulaturnotation als  
klingende Tonhöhe hinzugefügt
 werden:
Index: Documentation/de/texidocs/chord-glissando-in-tablature.texidoc
diff --git a/Documentation/de/texidocs/chord-glissando-in-tablature.texidoc  
b/Documentation/de/texidocs/chord-glissando-in-tablature.texidoc
index  
aa4a660e5cc854849455f03a853ed3155e73e93f..dd8b79c2e554b59aa0252e3354e6089b0e5bcf42  
100644
--- a/Documentation/de/texidocs/chord-glissando-in-tablature.texidoc
+++ b/Documentation/de/texidocs/chord-glissando-in-tablature.texidoc
@@ -3,8 +3,7 @@
 Gleiten von Akkorden kann sowohl im normalen Notensystem als auch in einer
 Tabulatur notiert werden.  Saitennummern werden für Tabulaturen
 benötigt, weil die automatische Saitenberechnung unterschiedlich für
-Akkorde und einzelne Noten funktioniert und
address@hidden zieht Linien zwischen einzelnen Noten.
+Akkorde und einzelne Noten funktioniert.
 "
   doctitlede = "Akkordglissando in Tabulaturen"

Index: Documentation/es/notation/fretted-strings.itely
diff --git a/Documentation/es/notation/fretted-strings.itely  
b/Documentation/es/notation/fretted-strings.itely
index  
908fa67ff5294c3cbd846f8e82d59ee1caa58a69..799648cae7ac6c74f4c0bc0b12324cf45fc192d7  
100644
--- a/Documentation/es/notation/fretted-strings.itely
+++ b/Documentation/es/notation/fretted-strings.itely
@@ -384,7 +384,6 @@ ties = \relative c' {
 @funindex \harmonic
 @funindex \harmonicByFret
 @funindex \harmonicByRatio
address@hidden \chordGlissando

 Se pueden añadir indicaciones de armónicos a la notación de tablatura
 como sus alturas de sonido:
Index: Documentation/es/texidocs/chord-glissando-in-tablature.texidoc
diff --git a/Documentation/es/texidocs/chord-glissando-in-tablature.texidoc  
b/Documentation/es/texidocs/chord-glissando-in-tablature.texidoc
index  
af8d3349e5ed0a1aaa80208abbb6915cb999af65..967585c3c7e71608cb116b5a58e58e4e7c09d765  
100644
--- a/Documentation/es/texidocs/chord-glissando-in-tablature.texidoc
+++ b/Documentation/es/texidocs/chord-glissando-in-tablature.texidoc
@@ -4,8 +4,7 @@
 Los deslizamientos para acordes se pueden indicar tanto en el contexto
 Staff como en TabStaff.  Los números de cuerda son necesarios para
 TabStaff porque los cálculos de cuerda automáticos son diferentes para
-los acordes y para notas sueltas, y @code{\\chordGlissando} traza
-líneas entre las notas individuales.
+los acordes y para notas sueltas.

 "

Index: Documentation/notation/fretted-strings.itely
diff --git a/Documentation/notation/fretted-strings.itely  
b/Documentation/notation/fretted-strings.itely
index  
850557f37c6873d836fa96f7b257648d616cec85..ec37a8636de44d962c601651b2274678451f55f0  
100644
--- a/Documentation/notation/fretted-strings.itely
+++ b/Documentation/notation/fretted-strings.itely
@@ -367,7 +367,6 @@ ties = \relative c' {
 @funindex \harmonic
 @funindex \harmonicByFret
 @funindex \harmonicByRatio
address@hidden \chordGlissando

 Harmonic indications can be added to tablature notation as sounding
 pitches:
Index: Documentation/snippets/new/chord-glissando-in-tablature.ly
diff --git a/Documentation/snippets/new/chord-glissando-in-tablature.ly  
b/Documentation/snippets/new/chord-glissando-in-tablature.ly
index  
1f5e08834d06d67a4e39bd9a0d7b1d1e74b229e0..cdf270278dedd738451be278fc9ffdf87a03d3b8  
100644
--- a/Documentation/snippets/new/chord-glissando-in-tablature.ly
+++ b/Documentation/snippets/new/chord-glissando-in-tablature.ly
@@ -5,15 +5,13 @@
   texidoc = "
 Slides for chords can be indicated in both Staff and TabStaff.
 String numbers are necessary for TabStaff because automatic
-string calculations are different for chords and for single notes,
-and @code{\chordGlissando} draws lines between single notes.
+string calculations are different for chords and for single notes.
 "
   doctitle = "Chord glissando in tablature"
 }

 myMusic = \relative c' {
-  \chordGlissando
-  <c\3 e\2 g\1>8 <f\3 a\2 c\1>
+  <c\3 e\2 g\1>1 \glissando <f\3 a\2 c\1>
 }

 \score {
Index: ly/music-functions-init.ly
diff --git a/ly/music-functions-init.ly b/ly/music-functions-init.ly
index  
e83470dc622f3eab4ebac697bf97a900a0510f49..9efa81ea65ef74609a53121415903397883546e4  
100644
--- a/ly/music-functions-init.ly
+++ b/ly/music-functions-init.ly
@@ -204,72 +204,6 @@ breathe =
    (_i "Insert a breath mark.")
    (make-music 'BreathingEvent))

-%%  Make slide indication for chords
-chordGlissando =
-#(define-music-function (parser location mus1 mus2) (ly:music? ly:music?)
-   "Make a glissando between the notes of triads @code{mus1} and  
@code{mus2}."
-
-   (define (add-glissando musChord)
-     (let ((els (ly:music-property musChord 'elements)))
-       (ly:music-set-property! musChord 'elements (append els (list  
(make-music 'GlissandoEvent))))
-       musChord))
-
-   (define (get-notes musicChord)
-     (filter (lambda(x) (eq? (ly:music-property x 'name) 'NoteEvent))
-             (ly:music-property musicChord 'elements)))
-
-   (define (select-note musChord index)
-     (let* ((notes (get-notes musChord))
-            (non-notes (filter (lambda (x)
-                                 (not (eq? (ly:music-property x 'name)
-                                           'NoteEvent)))
-                               (ly:music-property musChord 'elements)))
-            (selected-note (list-ref notes index))
-            (new-els (cons selected-note non-notes))
-            (new-mus (ly:music-deep-copy musChord)))
-       (ly:music-set-property! new-mus 'elements new-els)
-       new-mus))
-
-   (define (add-glissando-line mus1 mus2 index)
-     (context-spec-music
-      (context-spec-music
-       (make-sequential-music
-        (list
-         hideNotes
-         (make-grob-property-set 'StringNumber 'transparent #t)
-         (make-grob-property-set 'NoteColumn 'ignore-collision #t)
-         ;; obviously, this isn't equivalent to \once,
-         ;; so could be changed if required
-         (make-grob-property-set 'Glissando 'thickness 2)
-         (make-grob-property-set 'DynamicText 'transparent #t)
-         (make-grob-property-set 'DynamicLineSpanner 'transparent #t)
-         (make-grob-property-set 'DynamicTextSpanner 'transparent #t)
-        (make-grob-property-set 'TextScript 'stencil #f)
-         (add-glissando (select-note mus1 index))
-         (select-note mus2 index)))
-       'Bottom (symbol->string (gensym)))
-      'Staff))
-
-   (let* ((notes1 (get-notes mus1))
-          (notes2 (get-notes mus2))
-          (note-count (min (length notes1) (length notes2))))
-
-    #{
-       \once \override Glissando #'minimum-length = #4
-       \once \override Glissando #'springs-and-rods =  
#ly:spanner::set-spacing-rods
-     <<
-       {
-         $(add-glissando mus1)
-         $mus2
-       }
-       $(make-simultaneous-music
-           (map (lambda (x)
-                        (add-glissando-line mus1 mus2 x))
-                (iota note-count)))
-    >>
-    \revert NoteColumn #'ignore-collision
-  #}))
-
 clef =
 #(define-music-function (parser location type) (string?)
    (_i "Set the current clef to @var{type}.")