Fix "make doc" error: Character set messup in pdf-scheme.cc (issue4449061)

[jan . nieuwenhuizen]

LGTM

Some nitpicks, see below


http://codereview.appspot.com/4449061/diff/1/lily/pdf-scheme.cc
File lily/pdf-scheme.cc (left):

http://codereview.appspot.com/4449061/diff/1/lily/pdf-scheme.cc#oldcode41
lily/pdf-scheme.cc:41: if (!g) {
Please use gnu coding standards for brace placement

http://codereview.appspot.com/4449061/diff/1/lily/pdf-scheme.cc
File lily/pdf-scheme.cc (right):

http://codereview.appspot.com/4449061/diff/1/lily/pdf-scheme.cc#newcode36
lily/pdf-scheme.cc:36: const char *charset="UTF-8"; // Input is ALWAYS
UTF-8!
I think we never start with const: ie use char const * here. Then const
always applies to the left.

http://codereview.appspot.com/4449061/diff/1/lily/pdf-scheme.cc#newcode52
lily/pdf-scheme.cc:52: if (g_without_BOM) { // conversion to UTF-16be
might have failed, too
what about: you avoid casting and add an implicit comment about what
exacly is a bom.
char const* BOM = "\xff\xfe";
strcpy (g, BOM);

http://codereview.appspot.com/4449061/