[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: rest-collision.cc: adjust all rests in column. Issues 1618 and 1547
|
From: |
Carl . D . Sorensen |
|
Subject: |
Re: rest-collision.cc: adjust all rests in column. Issues 1618 and 1547 (issue4442083) |
|
Date: |
Sat, 30 Apr 2011 14:46:52 +0000 |
LGTM. A couple of non-essential comments.
http://codereview.appspot.com/4442083/diff/12001/input/regression/rest-polyphonic-2.ly
File input/regression/rest-polyphonic-2.ly (right):
http://codereview.appspot.com/4442083/diff/12001/input/regression/rest-polyphonic-2.ly#newcode5
input/regression/rest-polyphonic-2.ly:5: result in collision, but is
supressed if the rest has a pitch."
The texidoc should have a statement that describes what the output
should look like.
http://codereview.appspot.com/4442083/diff/12001/lily/rest-collision.cc
File lily/rest-collision.cc (right):
http://codereview.appspot.com/4442083/diff/12001/lily/rest-collision.cc#newcode281
lily/rest-collision.cc:281: "Move around ordinary rests (not
multi-measure-rests) to avoid"
Perhaps include pitched rests along with mult-measure-rests in the
description of rests not affected by this interface.
http://codereview.appspot.com/4442083/