|
From: | Carl . D . Sorensen |
Subject: | Re: separating flags from noteheads in font (issue4273119) |
Date: | Fri, 10 Jun 2011 23:12:15 +0000 |
Looks good, but untested. I'll test it when I can. http://codereview.appspot.com/4273119/diff/3001/mf/feta-noteheads.mf File mf/feta-noteheads.mf (right): http://codereview.appspot.com/4273119/diff/3001/mf/feta-noteheads.mf#newcode45 mf/feta-noteheads.mf:45: numeric black_notehead_width; Perhaps a comment here to indicate that we have deliberately *not* used a save statement for black_notehead_width in order to allow it to be a global variable available for other .mf files. This will help keep people from saying "Hey -- good practice says to make local variables; let's make it local" http://codereview.appspot.com/4273119/
[Prev in Thread] | Current Thread | [Next in Thread] |