lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: separating flags from noteheads in font (issue4273119)


From: Marc Hohl
Subject: Re: separating flags from noteheads in font (issue4273119)
Date: Fri, 17 Jun 2011 09:43:49 +0200
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.17) Gecko/20110424 Thunderbird/3.1.10

Am 16.06.2011 23:19, schrieb Carl Sorensen:


On 6/16/11 2:57 PM, "Janek Warchoł"<address@hidden>
wrote:

2011/6/14 Marc Hohl<address@hidden>:
Am 13.06.2011 22:16, schrieb Janek Warchoł:
2011/6/13 Janek Warchoł<address@hidden>:
Bad news: it doesn't work (the flags are squashed)
An idea came to my mind - maybe we can use our *.table files in
feta-flags?
Is it possible to tell our build system to compile feta-noteheads
first and feta-flags (which would contain a reference to
feta-noteheads.otf-gtable) second? Is this viable?
I don't know. I searched through the source files,
and IIUC black_notehead_width depends on the function draw_outside_ellipse
(defined in feta-noteheads.mf) and the puff_up_factor (defined in
feta-params.mf).

So while you are restructuring the metafont files anyway (well, kind of),
would it make sense to collect the drawing functions like
draw_outside_ellipse
in another file, perhaps feta-routines.mf?

Then you could include that file in both feta-noteheads.mf and feta-flags.mf
and call draw_outside_ellipse to compute the value of black_notehead_width.

I think this is easier to maintain than forcing an order in which the files
are handled during the build process, and it makes testing more easy,
because
the files are handled independently.

But this looks like a whole lot of work ... :-(
I don't think it would be too much work, but we will still have a problem:
if we move draw_outside_ellipse to feta-routines.mf and included that file
in both feta-flags and feta-noteheads, how will we ensure that
it will be called with the same parameters every time? (i.e. if someone
decides to change black notehead by tweaking the parameters of
draw_outside_ellipse in feta-noteheads, he may forget to change
its parameters in feta-flags. And even if he won't forget, it's still a non
elegant solution) We can solve this by moving these parameters
to feta-routines too, but then we will have noteheads' parameters
in two different places.
I agree with Janek's concern.  I think that black-notehead-width is properly
set in feta-noteheads.  And the proper solution is to make that value
global.
You are right. My proposal is still not completely consistent.
I'll spend some time on the airplane this week (I'm going to a conference in
Hawaii -- poor me ;) )
:-)

to see if I can figure out how to get
black-notehead-width global.

That would be great!

Regards,

Marc
Thanks,

Carl






reply via email to

[Prev in Thread] Current Thread [Next in Thread]