Re: GOP-PROP 3: C++ formatting (update)

[Jan Warchoł]

2011/7/3 Graham Percival <address@hidden>:
> On Sat, Jul 02, 2011 at 03:13:05PM -0700, Keith OHara wrote:
>> On Sat, 02 Jul 2011 13:19:23 -0700, Graham Percival <address@hidden> wrote:
>>
>> >[...] but I'd still want to run fixcc.py on the entire repo.
>>
>> Why run an indenter over the entire repository?
>> Simply having the indenter tool available for individual commits
>> would solve the problem.
>
> 1. newbies tend to trust that the existing material shows how they
> should do things.  It's confusing if we have to tell them not to
> follow the existing style.

+1 !!

> 2. if we indent files in conjunction with patches, then each patch
> will display a huge number of irrelevant changes -- given that
> we're changing the indentation tabs, pretty much the entire file
> will change.  Any important diffs will be lost in the sea of
> "everything changed" diffs.  Granted, git can avoid this with the
> ignore-whitespace diff option, but IIRC astyle and fixcc.py also
> produce some other changes.

+1 !

As for the actual formatting discussion, it got a bit too technical
for me, but i'm fine with any option you choose as long as it's easy
to use (automated as much as possible) and indents are in GNU-style.

cheers,
Janek