lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Adapt fixcc.py to use Astyle instead of emacs (issue4662074)


From: percival . music . ca
Subject: Re: Adapt fixcc.py to use Astyle instead of emacs (issue4662074)
Date: Sun, 03 Jul 2011 07:22:07 +0000

On 2011/07/03 02:41:15, Carl wrote:
Can you make it possible for us to see the diff caused by applying
this script
to the files you've mentioned?

I'll make a separate git branch showing the output once a few minor
issues are done.


Keith:
1. all // comments are now hard-left (i.e. in column 0).  Is that
intentional?  it looks weird in the diff.

2. some multi-line comments are still modofied:
diff --git a/lily/break-alignment-interface.cc
b/lily/break-alignment-interface.
index d368f83..0f08880 100644
--- a/lily/break-alignment-interface.cc
+++ b/lily/break-alignment-interface.cc
@@ -65,7 +65,7 @@ Break_alignment_interface::ordered_elements (Grob
*grob)

   vector<Grob *> writable_elts (elts);
   /*
-    Copy in order specified in BREAK-ALIGN-ORDER.
+   Copy in order specified in BREAK-ALIGN-ORDER.
   */
   vector<Grob *> new_elts;
   for (; scm_is_pair (order); order = scm_cdr (order))


#2 isn't important, but #1 looks like a bug.

Thanks so much for working on this!

Cheers,
- Graham

http://codereview.appspot.com/4662074/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]