Re: Adapt fixcc.py to use Astyle instead of emacs (issue4662074)

[Neil Puttock]

On 3 July 2011 14:39, Graham Percival <address@hidden> wrote:
> On Sun, Jul 03, 2011 at 02:25:12PM +0100, Neil Puttock wrote:
>>    Matrix<T, A> (vsize rows, vsize columns, T const &t)
>> -  : data_(rows * columns, t)
>> +    : data_ (rows *columns, t)
>>
>> misinterpreted multiplication sign
>
> heh, that one's funny!
>
>> --- a/flower/include/rational.hh
>> +++ b/flower/include/rational.hh
>> @@ -74,7 +74,8 @@ public:
>>    Rational (Rational const &r) { copy (r);}
>>    Rational &operator = (Rational const &r)
>>    {
>> -    copy (r); return *this;
>> +    copy (r);
>> +    return *this;
>>    }
>
> That looks fine?  astyle has a specific option to
> --keep-one-line-statements, but I think those are evil?

Sorry, I didn't mean to copy this bit (only the next part for the label).

>
>> -        b3:
>> +b3:
>>
>> goto label unindented
>
> We could use --indent-labels for this
>
>> --- a/lily/audio-item.cc
>> +++ b/lily/audio-item.cc
>> @@ -39,18 +39,12 @@ Audio_item::get_column () const
>>  }
>>
>>  Audio_item::Audio_item ()
>> -  : audio_column_ (0)
>> -  , channel_ (0)
>> +  : audio_column_ (0), channel_ (0)
>>  {
>>  }
>>
>> ctor init list move to single line
>
> I'm surprised astyle gets this wrong!

On a slight tangent: we might want a coding policy decision for init
lists (I understand they're more efficient).  So far, only Jan has
changed any files to use them (with the recent midi fixes).

Cheers,
Neil