Re: Fix issues 1259 and 1433 (\breakDynamicSpan and a spanner's style=#'none over a line break) (issue4630070)

[n . puttock]

LGTM.


http://codereview.appspot.com/4630070/diff/3002/input/regression/dynamics-alignment-breaker-linebreak.ly
File input/regression/dynamics-alignment-breaker-linebreak.ly (right):

http://codereview.appspot.com/4630070/diff/3002/input/regression/dynamics-alignment-breaker-linebreak.ly#newcode12
input/regression/dynamics-alignment-breaker-linebreak.ly:12:
c1_\dim\breakDynamicSpan
redundant \breakDynamicSpan

http://codereview.appspot.com/4630070/diff/3002/input/regression/dynamics-alignment-breaker-linebreak.ly#newcode15
input/regression/dynamics-alignment-breaker-linebreak.ly:15:
c,,1_\dim\breakDynamicSpan
redundant \breakDynamicSpan

http://codereview.appspot.com/4630070/diff/3002/input/regression/dynamics-alignment-breaker.ly
File input/regression/dynamics-alignment-breaker.ly (right):

http://codereview.appspot.com/4630070/diff/3002/input/regression/dynamics-alignment-breaker.ly#newcode19
input/regression/dynamics-alignment-breaker.ly:19: %   \breakDynamicSpan
remove

http://codereview.appspot.com/4630070/diff/3002/lily/dynamic-align-engraver.cc
File lily/dynamic-align-engraver.cc (right):

http://codereview.appspot.com/4630070/diff/3002/lily/dynamic-align-engraver.cc#newcode93
lily/dynamic-align-engraver.cc:93: programming_error ("Already have a
force-ended DynamicLineSpanner.");
"already have a force-ended DynamicLineSpanner"

http://codereview.appspot.com/4630070/diff/3002/lily/dynamic-align-engraver.cc#newcode163
lily/dynamic-align-engraver.cc:163: || (end && d == RIGHT &&
!line->get_bound (RIGHT)))
indent

http://codereview.appspot.com/4630070/