[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Does type checking for all context property sets. (issue4654090)
From: |
reinhold . kainhofer |
Subject: |
Re: Does type checking for all context property sets. (issue4654090) |
Date: |
Thu, 07 Jul 2011 11:02:59 +0000 |
http://codereview.appspot.com/4654090/diff/1/lily/context.cc
File lily/context.cc (right):
http://codereview.appspot.com/4654090/diff/1/lily/context.cc#newcode496
lily/context.cc:496: properties_dict ()->set (sym, val);
else if (do_internal_type_checking_global) {
assert(...);
}
Otherwise do_internaltype_checking_global won't give any indication that
something was wrong!
Also, without do_internal_type_checking_global set, I think we should
give some warning that the value was not assigned. Otherwise LilyPond
silently discards a user setting and the user has no idea why it doesn't
have any effect (if he e.g. uses a string instead of a symbol).
Also,
http://codereview.appspot.com/4654090/
- Does type checking for all context property sets. (issue4654090), mtsolo, 2011/07/06
- Re: Does type checking for all context property sets. (issue4654090),
reinhold . kainhofer <=
- Re: Does type checking for all context property sets. (issue4654090), mtsolo, 2011/07/10
- Re: Does type checking for all context property sets. (issue4654090), n . puttock, 2011/07/10
- Re: Does type checking for all context property sets. (issue4654090), pkx166h, 2011/07/10
- Re: Does type checking for all context property sets. (issue4654090), n . puttock, 2011/07/10
- Re: Does type checking for all context property sets. (issue4654090), mtsolo, 2011/07/11
- Re: Does type checking for all context property sets. (issue4654090), n . puttock, 2011/07/11
- Re: Does type checking for all context property sets. (issue4654090), mtsolo, 2011/07/12