lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Adds longas, maximas and non-standard tweaks to MultiMeasureRest (is


From: dak
Subject: Re: Adds longas, maximas and non-standard tweaks to MultiMeasureRest (issue4536068)
Date: Tue, 26 Jul 2011 16:30:44 +0000


http://codereview.appspot.com/4536068/diff/30001/lily/multi-measure-rest.cc
File lily/multi-measure-rest.cc (right):

http://codereview.appspot.com/4536068/diff/30001/lily/multi-measure-rest.cc#newcode254
lily/multi-measure-rest.cc:254: Stencil r (musfont->find_by_name
("rests." + to_string (k)));
On 2011/07/26 13:08:11, dak wrote:
This may calculate a name "rests.-1" instead of the valid "rests.M1".
Use
Rest::glyph_name instead, though it may also need fixing in that
regard.

This comment was erroneous: find_by_name actually converts - into M by
itself.  However, it might still be a good idea to use Rest::glyph_name
in order to get a glyph with the right style for the document.

http://codereview.appspot.com/4536068/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]