[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Fixes issue 40. (issue4801083)
From: |
n . puttock |
Subject: |
Re: Fixes issue 40. (issue4801083) |
Date: |
Tue, 09 Aug 2011 17:15:23 +0000 |
http://codereview.appspot.com/4801083/diff/8001/input/regression/glissando-accidental.ly
File input/regression/glissando-accidental.ly (right):
http://codereview.appspot.com/4801083/diff/8001/input/regression/glissando-accidental.ly#newcode8
input/regression/glissando-accidental.ly:8: a1 \glissando cis
a1\glissando
http://codereview.appspot.com/4801083/diff/8001/lily/line-spanner.cc
File lily/line-spanner.cc (right):
http://codereview.appspot.com/4801083/diff/8001/lily/line-spanner.cc#newcode113
lily/line-spanner.cc:113: Grob *acc = Note_column::accidentals
(bound_grob->get_parent (X_AXIS));
acc is an AccidentalPlacement, so should be renamed to avoid confusion.
As an AccidentalPlacement, it won't work very well with chords that have
accidentals far enough away from the head the glissando ends on, or
chord glissandos where some heads don't have accidentals:
\relative c, {
\clef bass
\override Glissando #'minimum-length = #6
\override Glissando #'springs-and-rods = #ly:spanner::set-spacing-rods
<cis gis' dis'>8[\glissando <d! a' e'>]
}
http://codereview.appspot.com/4801083/diff/8001/lily/line-spanner.cc#newcode380
lily/line-spanner.cc:380: "minimum-distance "
The docstring for this will need changing.
http://codereview.appspot.com/4801083/
- Fixes issue 40. (issue4801083), mtsolo, 2011/08/06
- Re: Fixes issue 40. (issue4801083), pkx166h, 2011/08/06
- Re: Fixes issue 40. (issue4801083), Carl . D . Sorensen, 2011/08/08
- Re: Fixes issue 40. (issue4801083), mtsolo, 2011/08/08
- Re: Fixes issue 40. (issue4801083), Carl . D . Sorensen, 2011/08/08
- Re: Fixes issue 40. (issue4801083), hanwenn, 2011/08/09
- Re: Fixes issue 40. (issue4801083), mtsolo, 2011/08/09
- Re: Fixes issue 40. (issue4801083),
n . puttock <=
- Re: Fixes issue 40. (issue4801083), n . puttock, 2011/08/09
- Re: Fixes issue 40. (issue4801083), n . puttock, 2011/08/09