Re: Fix 1214: cueDuring and quoteDuring should also quote voices that create subvoices (issue4816044)

[n . puttock]

LGTM.


http://codereview.appspot.com/4816044/diff/15001/input/regression/quote-during-subvoice.ly
File input/regression/quote-during-subvoice.ly (right):

http://codereview.appspot.com/4816044/diff/15001/input/regression/quote-during-subvoice.ly#newcode1
input/regression/quote-during-subvoice.ly:1: \version "2.15.6"
2.15.9

http://codereview.appspot.com/4816044/diff/15001/input/regression/quote-during-subvoice.ly#newcode18
input/regression/quote-during-subvoice.ly:18: \addQuote quoteMe \quoteMe
"quoteMe"

http://codereview.appspot.com/4816044/diff/15001/input/regression/quote-during-subvoice.ly#newcode26
input/regression/quote-during-subvoice.ly:26: \addQuote quoteMeI
\quoteMeI
"quoteMeI"

http://codereview.appspot.com/4816044/diff/15001/input/regression/quote-during-subvoice.ly#newcode34
input/regression/quote-during-subvoice.ly:34: \addQuote quoteMeII
\quoteMeII
"quoteMeII"

http://codereview.appspot.com/4816044/diff/15001/input/regression/quote-during-subvoice.ly#newcode42
input/regression/quote-during-subvoice.ly:42: \addQuote quoteMeIII
\quoteMeIII
"quoteMeIII"

http://codereview.appspot.com/4816044/diff/15001/scm/part-combiner.scm
File scm/part-combiner.scm (right):

http://codereview.appspot.com/4816044/diff/15001/scm/part-combiner.scm#newcode574
scm/part-combiner.scm:574: (voicename (get-next-unique-voice-name))
indent

(most of the following lines are also out by at least a space)

http://codereview.appspot.com/4816044/diff/15001/scm/part-combiner.scm#newcode578
scm/part-combiner.scm:578: (ly:parser-lookup parser
'partCombineListener))))
indent

http://codereview.appspot.com/4816044/diff/15001/scm/part-combiner.scm#newcode582
scm/part-combiner.scm:582: ;; If the context-specced quoted music does
not contain anything, try to
indent

http://codereview.appspot.com/4816044/diff/15001/scm/part-combiner.scm#newcode586
scm/part-combiner.scm:586: (let find-non-empty ((current-tail (member
raw-voice context-list)))
indent

http://codereview.appspot.com/4816044/diff/15001/scm/part-combiner.scm#newcode589
scm/part-combiner.scm:589: ((null? current-tail) #f)
indent

http://codereview.appspot.com/4816044/diff/15001/scm/part-combiner.scm#newcode592
scm/part-combiner.scm:592: (set! quote-contents (cdar current-tail)))
indent

http://codereview.appspot.com/4816044/diff/15001/scm/part-combiner.scm#newcode597
scm/part-combiner.scm:597: (ly:music-message mus (ly:format (_ "quoted
music `~a' is empty") name) ))))
name)))))

http://codereview.appspot.com/4816044/