[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Fixes boolean/SCM confusions, part 1. (issue 4875054)
From: |
bordage . bertrand |
Subject: |
Re: Fixes boolean/SCM confusions, part 1. (issue 4875054) |
Date: |
Thu, 18 Aug 2011 13:31:26 +0000 |
(Two minor comments however).
http://codereview.appspot.com/4875054/diff/1/lily/auto-beam-engraver.cc
File lily/auto-beam-engraver.cc (right):
http://codereview.appspot.com/4875054/diff/1/lily/auto-beam-engraver.cc#newcode172
lily/auto-beam-engraver.cc:172: return !scm_is_false (scm_call_4
(get_property ("autoBeamCheck"),
Indent like this:
return !scm_is_false (scm_call_4 (
get_property ("autoBeamCheck"),
context ()->self_scm (),
[...]
http://codereview.appspot.com/4875054/diff/1/lily/bar-check-iterator.cc
File lily/bar-check-iterator.cc (right):
http://codereview.appspot.com/4875054/diff/1/lily/bar-check-iterator.cc#newcode56
lily/bar-check-iterator.cc:56: SCM sync = tr->get_property
("barCheckSynchronize");
Maybe you should also merge this line and line 65?
But some will find it more convenient to see the properties defined
here, so I don't know what is better.
http://codereview.appspot.com/4875054/
- Fixes boolean/SCM confusions, part 1. (issue 4875054), cecile . hauchemaille, 2011/08/18
- Re: Fixes boolean/SCM confusions, part 1. (issue 4875054), bordage . bertrand, 2011/08/18
- Re: Fixes boolean/SCM confusions, part 1. (issue 4875054),
bordage . bertrand <=
- Re: Fixes boolean/SCM confusions, part 1. (issue 4875054), reinhold . kainhofer, 2011/08/18
- Re: Fixes boolean/SCM confusions, part 1. (issue 4875054), cecile . hauchemaille, 2011/08/18
- Re: Fixes boolean/SCM confusions, part 1. (issue 4875054), dak, 2011/08/18
- Re: Fixes boolean/SCM confusions, part 1. (issue 4875054), reinhold . kainhofer, 2011/08/18
- Re: Fixes boolean/SCM confusions, part 1. (issue 4875054), n . puttock, 2011/08/18
- Re: Fixes boolean/SCM confusions, part 1. (issue 4875054), dak, 2011/08/18
- Re: Fixes boolean/SCM confusions, part 1. (issue 4875054), dak, 2011/08/18
- Re: Fixes boolean/SCM confusions, part 1. (issue 4875054), Carl . D . Sorensen, 2011/08/18
- Re: Fixes boolean/SCM confusions, part 1. (issue 4875054), cecile . hauchemaille, 2011/08/18
- Re: Fixes boolean/SCM confusions, part 1. (issue 4875054), dak, 2011/08/18