|
From: | n . puttock |
Subject: | Re: Fixes boolean/SCM confusions, part 1. (issue 4875054) |
Date: | Thu, 18 Aug 2011 14:24:44 +0000 |
http://codereview.appspot.com/4875054/diff/8002/lily/accidental-engraver.cc File lily/accidental-engraver.cc (right): http://codereview.appspot.com/4875054/diff/8002/lily/accidental-engraver.cc#newcode319 lily/accidental-engraver.cc:319: if (scm_to_int (left_objects_[i]->get_property ("side-axis")) == X_AXIS) this is potentially unsafe, but only since the type predicate for side-axis is number? rather than integer? (a type predicate exclusive to axis is probably not worth the effort) http://codereview.appspot.com/4875054/
[Prev in Thread] | Current Thread | [Next in Thread] |