Re: Cleaned up style (issue 4951062)

[Carl . D . Sorensen]

Looks very promising.

A couple of style comments.

I think the naming should be revised to include Kievan as part of the
name, at least for the notes like s1.

Thanks,

Carl



http://codereview.appspot.com/4951062/diff/1/mf/feta-kievan.mf
File mf/feta-kievan.mf (right):

http://codereview.appspot.com/4951062/diff/1/mf/feta-kievan.mf#newcode28
mf/feta-kievan.mf:28: % this draws the quarter note with the stem down
Is this indented with tabs?  We use tabs in metafont files.

http://codereview.appspot.com/4951062/diff/1/mf/feta-kievan.mf#newcode78
mf/feta-kievan.mf:78: fill z1{dir -6.9} .. z2 .. z3 & z3 .. z4 .. z5 &
z5 -- z6 & z6 .. z7 .. z8 & z8{left} .. z9 & z9 .. z10 ... {dir
-76.9}cycle;
I know that Werner left a review somewhere on a font change that showed
the proper way to break lines in a case like this.

Looking, for example, at feta-noteheads.mf line 636, we see that the
proper format for this command would be

fill z1{dir -6.9}
     .. z2
     .. z3
     & z3
     .. z4
     .. z5
     & z5
     -- z6
     & z6
     .. z7
     .. z8 & z8{left}
     .. z9 & z9
     .. z10
     ... {dir -76.9}cycle;

I guess we should add something about this to the CG.  I'll do it
tonight.

http://codereview.appspot.com/4951062/diff/6001/mf/feta-kievan.mf
File mf/feta-kievan.mf (right):

http://codereview.appspot.com/4951062/diff/6001/mf/feta-kievan.mf#newcode215
mf/feta-kievan.mf:215: fet_beginchar ("kievan whole note", "s1");
The name should probably not be s1, since that's the name of the
standard whole note glyph.

Look at the parmesan note naming for the kind of names you should
probably use for the kievan glyphs.  Something like s1Keivan.

http://codereview.appspot.com/4951062/