[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
parser.yy et al: Turn \transpose into a music function, make other music
From: |
reinhold . kainhofer |
Subject: |
parser.yy et al: Turn \transpose into a music function, make other music functions use ly:pitch? (issue 4991049) |
Date: |
Fri, 09 Sep 2011 14:53:32 +0000 |
LGTM
http://codereview.appspot.com/4991049/diff/2001/ly/music-functions-init.ly
File ly/music-functions-init.ly (right):
http://codereview.appspot.com/4991049/diff/2001/ly/music-functions-init.ly#newcode852
ly/music-functions-init.ly:852: pitch)))
indent (or better, write the whole lambda in one line).
BTW, that's a nice catch that this function can be implemented so easy!
http://codereview.appspot.com/4991049/diff/2001/ly/music-functions-init.ly#newcode876
ly/music-functions-init.ly:876: (if (string? finger) 'text 'digit)
remove tab in the middle of the line;
Use 8 spaces instead of tabs (even if the old code also had tabs. We
want to get away from tabs ASAP).
http://codereview.appspot.com/4991049/
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- parser.yy et al: Turn \transpose into a music function, make other music functions use ly:pitch? (issue 4991049),
reinhold . kainhofer <=